From 40b6f828237d2329b2f6b08e7582e1e230876dac Mon Sep 17 00:00:00 2001
From: DreamMaoMao <2523610504@qq.com>
Date: Thu, 6 Nov 2025 14:14:02 +0800
Subject: [PATCH] fix: fix ov_tab_mode arg

---
 config.conf                | 2 +-
 src/config/parse_config.h  | 1 +
 src/dispatch/bind_define.h | 6 +-----
 src/mango.c                | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/config.conf b/config.conf
index 59e4631..4c8d8d3 100644
--- a/config.conf
+++ b/config.conf
@@ -242,7 +242,7 @@ bind=CTRL+ALT,Right,resizewin,+50,+0
 mousebind=SUPER,btn_left,moveresize,curmove
 mousebind=NONE,btn_middle,togglemaximizescreen,0
 mousebind=SUPER,btn_right,moveresize,curresize
-mousebind=NONE,btn_left,toggleoverview,-1
+mousebind=NONE,btn_left,toggleoverview,1
 mousebind=NONE,btn_right,killclient,0
 
 # Axis Bindings
diff --git a/src/config/parse_config.h b/src/config/parse_config.h
index 36aa1db..a20a60a 100644
--- a/src/config/parse_config.h
+++ b/src/config/parse_config.h
@@ -880,6 +880,7 @@ FuncType parse_func_name(char *func_name, Arg *arg, char *arg_value,
 		func = toggleglobal;
 	} else if (strcmp(func_name, "toggleoverview") == 0) {
 		func = toggleoverview;
+		(*arg).i = atoi(arg_value);
 	} else if (strcmp(func_name, "set_proportion") == 0) {
 		func = set_proportion;
 		(*arg).f = atof(arg_value);
diff --git a/src/dispatch/bind_define.h b/src/dispatch/bind_define.h
index 57efa88..b5a4482 100644
--- a/src/dispatch/bind_define.h
+++ b/src/dispatch/bind_define.h
@@ -1447,7 +1447,7 @@ int minimized(const Arg *arg) {
 int toggleoverview(const Arg *arg) {
 	Client *c = NULL;
 
-	if (selmon->isoverview && ov_tab_mode && arg->i != -1 && selmon->sel) {
+	if (selmon->isoverview && ov_tab_mode && arg->i != 1 && selmon->sel) {
 		focusstack(&(Arg){.i = 1});
 		return 0;
 	}
@@ -1498,10 +1498,6 @@ int toggleoverview(const Arg *arg) {
 
 	view(&(Arg){.ui = target}, false);
 
-	if (ov_tab_mode && selmon->isoverview && selmon->sel) {
-		focusstack(&(Arg){.i = 1});
-	}
-
 	refresh_monitors_workspaces_status(selmon);
 	return 0;
 }
diff --git a/src/mango.c b/src/mango.c
index 2d6f1f7..e946d41 100644
--- a/src/mango.c
+++ b/src/mango.c
@@ -3406,7 +3406,7 @@ void keypress(struct wl_listener *listener, void *data) {
 		 keycode == 134 || keycode == 105 || keycode == 108 || keycode == 62) &&
 		selmon && selmon->sel) {
 		if (selmon->isoverview && selmon->sel) {
-			toggleoverview(&(Arg){.i = -1});
+			toggleoverview(&(Arg){.i = 1});
 		}
 	}