opt: optimize code struct

opt: allow ime in on-demand layer
opt: re-judge the focus strategy of the layer when re-arrangelayer
2025-11-28 12:49:06 +08:00 · 2025-11-28 12:42:18 +08:00 · 2025-11-28 12:15:47 +08:00
6 changed files with 48 additions and 118 deletions
--- a/flake.lock
+++ b/flake.lock
@@ -18,27 +18,6 @@
        "type": "github"
      }
    },
-    "flake-utils": {
-      "inputs": {
-        "systems": [
-          "scenefx",
-          "systems"
-        ]
-      },
-      "locked": {
-        "lastModified": 1731533236,
-        "narHash": "sha256-l0KFg5HjrsfsO/JpG+r7fRrqm12kzFHyUHqHCVpMMbI=",
-        "owner": "numtide",
-        "repo": "flake-utils",
-        "rev": "11707dc2f618dd54ca8739b309ec4fc024de578b",
-        "type": "github"
-      },
-      "original": {
-        "owner": "numtide",
-        "repo": "flake-utils",
-        "type": "github"
-      }
-    },
    "nixpkgs": {
      "locked": {
        "lastModified": 1750386251,
@@ -79,18 +58,16 @@
    },
    "scenefx": {
      "inputs": {
-        "flake-utils": "flake-utils",
        "nixpkgs": [
          "nixpkgs"
-        ],
-        "systems": "systems"
+        ]
      },
      "locked": {
-        "lastModified": 1762447505,
-        "narHash": "sha256-VEBQ8KXkSS4c+kdAhmvq06lEd9WNeCXdRK1U+qSilFw=",
+        "lastModified": 1750785057,
+        "narHash": "sha256-tGX6j4W91rcb+glXJo43sjPI9zQvPotonknG1BdihR4=",
        "owner": "wlrfx",
        "repo": "scenefx",
-        "rev": "7f9e7409f6169fa637f1265895c121a8f8b70272",
+        "rev": "3a6cfb12e4ba97b43326357d14f7b3e40897adfc",
        "type": "github"
      },
      "original": {
@@ -98,21 +75,6 @@
        "repo": "scenefx",
        "type": "github"
      }
-    },
-    "systems": {
-      "locked": {
-        "lastModified": 1689347949,
-        "narHash": "sha256-12tWmuL2zgBgZkdoB6qXZsgJEH9LR3oUgpaQq2RbI80=",
-        "owner": "nix-systems",
-        "repo": "default-linux",
-        "rev": "31732fcf5e8fea42e59c2488ad31a0e651500f68",
-        "type": "github"
-      },
-      "original": {
-        "owner": "nix-systems",
-        "repo": "default-linux",
-        "type": "github"
-      }
    }
  },
  "root": "root",
--- a/flake.nix
+++ b/flake.nix
@@ -25,13 +25,12 @@

      perSystem = {
        config,
-        system,
        pkgs,
        ...
      }: let
-        inherit (pkgs) callPackage;
+        inherit (pkgs) callPackage ;
        mango = callPackage ./nix {
-          scenefx = inputs.scenefx.packages.${system}.default;
+          inherit (inputs.scenefx.packages.${pkgs.stdenv.hostPlatform.system}) scenefx;
        };
        shellOverride = old: {
          nativeBuildInputs = old.nativeBuildInputs ++ [];
--- a/src/animation/client.h
+++ b/src/animation/client.h
@@ -245,10 +245,6 @@ void buffer_set_effect(Client *c, BufferData data) {
 		data.corner_location = CORNER_LOCATION_NONE;
 	}

-	if (blur && !c->noblur) {
-		wlr_scene_blur_set_corner_radius(c->blur, border_radius,
-										 data.corner_location);
-	}
 	wlr_scene_node_for_each_buffer(&c->scene_surface->node,
 								   scene_buffer_apply_effect, &data);
 }
@@ -353,19 +349,6 @@ void client_draw_shadow(Client *c) {
 	wlr_scene_shadow_set_clipped_region(c->shadow, clipped_region);
 }

-void client_draw_blur(Client *c, struct wlr_box clip_box, struct ivec2 offset) {
-	if (blur && !c->noblur) {
-		if (c->scene_surface->node.enabled && !c->blur->node.enabled)
-			wlr_scene_node_set_enabled(&c->blur->node, true);
-		wlr_scene_node_set_position(&c->blur->node, offset.x, offset.y);
-		wlr_scene_blur_set_size(c->blur, clip_box.width - c->bw,
-								clip_box.height - c->bw);
-	} else {
-		if (c->blur->node.enabled)
-			wlr_scene_node_set_enabled(&c->blur->node, false);
-	}
-}
-
 void apply_border(Client *c) {
 	if (!c || c->iskilling || !client_surface(c)->mapped)
 		return;
@@ -550,14 +533,12 @@ void client_apply_clip(Client *c, float factor) {

 		apply_border(c);
 		client_draw_shadow(c);
-		client_draw_blur(c, clip_box, offset);

 		if (clip_box.width <= 0 || clip_box.height <= 0) {
 			return;
 		}

 		wlr_scene_subsurface_tree_set_clip(&c->scene_surface->node, &clip_box);
-
 		buffer_set_effect(c, (BufferData){1.0f, 1.0f, clip_box.width,
 										  clip_box.height,
 										  current_corner_location, true});
@@ -589,7 +570,6 @@ void client_apply_clip(Client *c, float factor) {
 	// 应用窗口装饰
 	apply_border(c);
 	client_draw_shadow(c);
-	client_draw_blur(c, clip_box, offset);

 	// 如果窗口剪切区域已经剪切到0，则不渲染窗口表面
 	if (clip_box.width <= 0 || clip_box.height <= 0) {
@@ -1011,10 +991,6 @@ void resize(Client *c, struct wlr_box geo, int interact) {
 		apply_border(c);
 		client_get_clip(c, &clip);
 		wlr_scene_subsurface_tree_set_clip(&c->scene_surface->node, &clip);
-		if (blur && !c->noblur)
-			wlr_scene_blur_set_size(c->blur,
-									c->animation.current.width - 2 * c->bw,
-									c->animation.current.height - 2 * c->bw);
 		return;
 	}
 	// 如果不是工作区切换时划出去的窗口，就让动画的结束位置，就是上面的真实位置和大小
--- a/src/animation/common.h
+++ b/src/animation/common.h
@@ -158,6 +158,12 @@ static bool scene_node_snapshot(struct wlr_scene_node *node, int lx, int ly,
 										   scene_buffer->corner_radius,
 										   scene_buffer->corners);

+		// wlr_scene_buffer_set_backdrop_blur_optimized(
+		// 	snapshot_buffer, scene_buffer->backdrop_blur_optimized);
+		// wlr_scene_buffer_set_backdrop_blur_ignore_transparent(
+		// 	snapshot_buffer, scene_buffer->backdrop_blur_ignore_transparent);
+		wlr_scene_buffer_set_backdrop_blur(snapshot_buffer, false);
+
 		snapshot_buffer->node.data = scene_buffer->node.data;

 		struct wlr_scene_surface *scene_surface =
@@ -192,8 +198,6 @@ static bool scene_node_snapshot(struct wlr_scene_node *node, int lx, int ly,

 		break;
 	}
-	case WLR_SCENE_NODE_BLUR:
-		break;
 	case WLR_SCENE_NODE_OPTIMIZED_BLUR:
 		return true;
 	}
--- a/src/animation/layer.h
+++ b/src/animation/layer.h
@@ -356,10 +356,6 @@ void layer_animation_next_tick(LayerSurface *l) {
 		.height = height,
 	};

-	if (blur && blur_layer && !l->noblur && l->blur)
-		wlr_scene_blur_set_size(l->blur, l->animation.current.width,
-								l->animation.current.height);
-
 	if (animation_passed >= 1.0) {
 		l->animation.running = false;
 		l->need_output_flush = false;
--- a/src/mango.c
+++ b/src/mango.c
@@ -285,7 +285,6 @@ struct Client {
 	struct wlr_scene_tree *scene;
 	struct wlr_scene_rect *border; /* top, bottom, left, right */
 	struct wlr_scene_shadow *shadow;
-	struct wlr_scene_blur *blur;
 	struct wlr_scene_tree *scene_surface;
 	struct wl_list link;
 	struct wl_list flink;
@@ -424,7 +423,6 @@ typedef struct {
 	struct wlr_scene_tree *scene;
 	struct wlr_scene_tree *popups;
 	struct wlr_scene_shadow *shadow;
-	struct wlr_scene_blur *blur;
 	struct wlr_scene_layer_surface_v1 *scene_layer;
 	struct wl_list link;
 	struct wl_list fadeout_link;
@@ -1559,12 +1557,19 @@ void apply_window_snap(Client *c) {
 	resize(c, c->geom, 0);
 }

+void focuslayer(LayerSurface *l) {
+	focusclient(NULL, 0);
+	dwl_im_relay_set_focus(dwl_input_method_relay, l->layer_surface->surface);
+	client_notify_enter(l->layer_surface->surface, wlr_seat_get_keyboard(seat));
+}
+
 void reset_exclusive_layer(Monitor *m) {
 	LayerSurface *l = NULL;
 	int i;
 	unsigned int layers_above_shell[] = {
 		ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY,
 		ZWLR_LAYER_SHELL_V1_LAYER_TOP,
+		ZWLR_LAYER_SHELL_V1_LAYER_BOTTOM,
 	};

 	if (!m)
@@ -1572,18 +1577,24 @@ void reset_exclusive_layer(Monitor *m) {

 	for (i = 0; i < (int)LENGTH(layers_above_shell); i++) {
 		wl_list_for_each_reverse(l, &m->layers[layers_above_shell[i]], link) {
+			if (l == exclusive_focus &&
+				l->layer_surface->current.keyboard_interactive !=
+					ZWLR_LAYER_SURFACE_V1_KEYBOARD_INTERACTIVITY_EXCLUSIVE)
+				exclusive_focus = NULL;
+			if (l->layer_surface->current.keyboard_interactive ==
+					ZWLR_LAYER_SURFACE_V1_KEYBOARD_INTERACTIVITY_NONE &&
+				l->layer_surface->surface ==
+					seat->keyboard_state.focused_surface)
+				focusclient(focustop(selmon), 1);
+
 			if (locked ||
 				l->layer_surface->current.keyboard_interactive !=
 					ZWLR_LAYER_SURFACE_V1_KEYBOARD_INTERACTIVITY_EXCLUSIVE ||
 				!l->mapped || l == exclusive_focus)
 				continue;
 			/* Deactivate the focused client. */
-			focusclient(NULL, 0);
 			exclusive_focus = l;
-			dwl_im_relay_set_focus(dwl_input_method_relay,
-								   l->layer_surface->surface);
-			client_notify_enter(l->layer_surface->surface,
-								wlr_seat_get_keyboard(seat));
+			focuslayer(l);
 			return;
 		}
 	}
@@ -1884,11 +1895,7 @@ buttonpress(struct wl_listener *listener, void *data) {
 			if (l && !exclusive_focus &&
 				l->layer_surface->current.keyboard_interactive ==
 					ZWLR_LAYER_SURFACE_V1_KEYBOARD_INTERACTIVITY_ON_DEMAND) {
-				focusclient(NULL, 0);
-				dwl_im_relay_set_focus(dwl_input_method_relay,
-									   l->layer_surface->surface);
-				client_notify_enter(l->layer_surface->surface,
-									wlr_seat_get_keyboard(seat));
+				focuslayer(l);
 			}
 		}

@@ -2145,16 +2152,12 @@ static void iter_layer_scene_buffers(struct wlr_scene_buffer *buffer, int sx,
 		return;
 	}

-	LayerSurface *l = (LayerSurface *)user_data;
-
-	wlr_scene_node_set_enabled(&l->blur->node, true);
-	wlr_scene_blur_set_transparency_mask_source(l->blur, buffer);
-	wlr_scene_blur_set_size(l->blur, l->geom.width, l->geom.height);
-
+	wlr_scene_buffer_set_backdrop_blur(buffer, true);
+	wlr_scene_buffer_set_backdrop_blur_ignore_transparent(buffer, true);
 	if (blur_optimized) {
-		wlr_scene_blur_set_should_only_blur_bottom_layer(l->blur, true);
+		wlr_scene_buffer_set_backdrop_blur_optimized(buffer, true);
 	} else {
-		wlr_scene_blur_set_should_only_blur_bottom_layer(l->blur, false);
+		wlr_scene_buffer_set_backdrop_blur_optimized(buffer, false);
 	}
 }

@@ -2199,17 +2202,13 @@ void maplayersurfacenotify(struct wl_listener *listener, void *data) {
 	}

 	// 初始化阴影
-	if (layer_surface->current.layer != ZWLR_LAYER_SHELL_V1_LAYER_BOTTOM &&
+	if (layer_surface->current.exclusive_zone == 0 &&
+		layer_surface->current.layer != ZWLR_LAYER_SHELL_V1_LAYER_BOTTOM &&
 		layer_surface->current.layer != ZWLR_LAYER_SHELL_V1_LAYER_BACKGROUND) {
-		if (layer_surface->current.exclusive_zone == 0) {
-			l->shadow = wlr_scene_shadow_create(l->scene, 0, 0, border_radius,
-												shadows_blur, shadowscolor);
-			wlr_scene_node_lower_to_bottom(&l->shadow->node);
-			wlr_scene_node_set_enabled(&l->shadow->node, true);
-		}
-
-		l->blur = wlr_scene_blur_create(l->scene, 0, 0);
-		wlr_scene_node_lower_to_bottom(&l->blur->node);
+		l->shadow = wlr_scene_shadow_create(l->scene, 0, 0, border_radius,
+											shadows_blur, shadowscolor);
+		wlr_scene_node_lower_to_bottom(&l->shadow->node);
+		wlr_scene_node_set_enabled(&l->shadow->node, true);
 	}

 	// 初始化动画
@@ -2225,9 +2224,7 @@ void maplayersurfacenotify(struct wl_listener *listener, void *data) {
 	if (!exclusive_focus &&
 		l->layer_surface->current.keyboard_interactive ==
 			ZWLR_LAYER_SURFACE_V1_KEYBOARD_INTERACTIVITY_ON_DEMAND) {
-		focusclient(NULL, 0);
-		client_notify_enter(l->layer_surface->surface,
-							wlr_seat_get_keyboard(seat));
+		focuslayer(l);
 	}
 }

@@ -2275,8 +2272,7 @@ void commitlayersurfacenotify(struct wl_listener *listener, void *data) {
 		if (!l->noblur &&
 			layer_surface->current.layer != ZWLR_LAYER_SHELL_V1_LAYER_BOTTOM &&
 			layer_surface->current.layer !=
-				ZWLR_LAYER_SHELL_V1_LAYER_BACKGROUND &&
-			l->blur) {
+				ZWLR_LAYER_SHELL_V1_LAYER_BACKGROUND) {

 			wlr_scene_node_for_each_buffer(&l->scene->node,
 										   iter_layer_scene_buffers, l);
@@ -3614,15 +3610,15 @@ static void iter_xdg_scene_buffers(struct wlr_scene_buffer *buffer, int sx,
 		return;

 	if (blur && c && !c->noblur) {
-		wlr_scene_node_set_enabled(&c->blur->node, true);
-		// wlr_scene_blur_set_transparency_mask_source(c->blur, buffer);
+		wlr_scene_buffer_set_backdrop_blur(buffer, true);
+		wlr_scene_buffer_set_backdrop_blur_ignore_transparent(buffer, false);
 		if (blur_optimized) {
-			wlr_scene_blur_set_should_only_blur_bottom_layer(c->blur, true);
+			wlr_scene_buffer_set_backdrop_blur_optimized(buffer, true);
 		} else {
-			wlr_scene_blur_set_should_only_blur_bottom_layer(c->blur, false);
+			wlr_scene_buffer_set_backdrop_blur_optimized(buffer, false);
 		}
 	} else {
-		wlr_scene_node_set_enabled(&c->blur->node, false);
+		wlr_scene_buffer_set_backdrop_blur(buffer, false);
 	}
 }

@@ -3737,9 +3733,6 @@ mapnotify(struct wl_listener *listener, void *data) {
 	c->shadow = wlr_scene_shadow_create(c->scene, 0, 0, border_radius,
 										shadows_blur, shadowscolor);

-	c->blur = wlr_scene_blur_create(c->scene_surface, 0, 0);
-	wlr_scene_node_lower_to_bottom(&c->blur->node);
-
 	wlr_scene_node_lower_to_bottom(&c->shadow->node);
 	wlr_scene_node_set_enabled(&c->shadow->node, true);
Author	SHA1	Message	Date
DreamMaoMao	16368a8781	opt: optimize code struct Some checks failed Close manually marked stale issues / close-issues (push) Has been cancelled Details Lock Threads / lock (push) Has been cancelled Details	2025-11-28 12:49:06 +08:00
DreamMaoMao	b768f72eaa	opt: allow ime in on-demand layer	2025-11-28 12:42:18 +08:00
DreamMaoMao	28ab0e6343	opt: re-judge the focus strategy of the layer when re-arrangelayer	2025-11-28 12:15:47 +08:00